feat(DateTimeRange): add AutoClose parameter by ArgoZhang · Pull Request #5802 · dotnetcore/BootstrapBlazor

ArgoZhang · 2025-04-09T04:57:33Z

Link issues

Summary By Copilot

This pull request introduces new functionality to the DateTimeRange component, including the ability to automatically close the popup when a date range is selected. It also updates the documentation and tests to reflect these changes.

Enhancements to DateTimeRange component:

src/BootstrapBlazor.Server/Components/Samples/DateTimeRanges.razor: Added the AutoClose attribute to enable automatic closing of the popup when a date range is selected.
src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs: Introduced the AutoClose parameter and updated the UpdateValue method to close the popup automatically if the AutoClose attribute is set to true and both start and end dates are selected. [1] [2]

Documentation updates:

src/BootstrapBlazor.Server/Locales/en-US.json: Updated the BindValueIntro to include information about the new AutoClose attribute.
src/BootstrapBlazor.Server/Locales/zh-CN.json: Updated the BindValueIntro to include information about the new AutoClose attribute.

Version update:

src/BootstrapBlazor/BootstrapBlazor.csproj: Incremented the version number from 9.5.4 to 9.5.5.

Test updates:

test/UnitTest/Components/DateTimeRangeTest.cs: Added tests to verify the functionality of the AutoClose attribute, ensuring the popup closes automatically upon date selection. [1] [2]

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Summary by Sourcery

Add AutoClose parameter to DateTimeRange component to automatically close the popup when a date range is selected

New Features:

Introduce an AutoClose parameter for DateTimeRange component that automatically closes the popup when both start and end dates are selected

Enhancements:

Update UpdateValue method to support automatic popup closing based on AutoClose parameter

Documentation:

Update documentation to include information about the new AutoClose attribute

Tests:

Add test cases to verify the AutoClose functionality of the DateTimeRange component

sourcery-ai · 2025-04-09T04:57:38Z

Reviewer's Guide by Sourcery

This pull request introduces the AutoClose parameter to the DateTimeRange component, which enables automatic closing of the popup after a date range is selected. The PR includes implementation changes, documentation updates, and new unit tests to verify the functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Introduced the `AutoClose` parameter to the `DateTimeRange` component, enabling automatic popup closure after date range selection.	Added the `AutoClose` parameter to the `DateTimeRange` component. Modified the `UpdateValue` method to automatically close the popup when `AutoClose` is enabled and both start and end dates are selected.	`src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs`
Added a demo of the `AutoClose` parameter to the DateTimeRanges sample.	Added the `AutoClose` attribute to the `DateTimeRange` component in the sample.	`src/BootstrapBlazor.Server/Components/Samples/DateTimeRanges.razor`
Updated documentation to include information about the new `AutoClose` attribute.	Updated the `BindValueIntro` in the English localization file. Updated the `BindValueIntro` in the Chinese localization file.	`src/BootstrapBlazor.Server/Locales/en-US.json` `src/BootstrapBlazor.Server/Locales/zh-CN.json`
Added tests to verify the functionality of the `AutoClose` attribute.	Added test cases to ensure the popup closes automatically upon date selection when `AutoClose` is enabled.	`test/UnitTest/Components/DateTimeRangeTest.cs`
Incremented the version number.	Incremented the version number from 9.5.4 to 9.5.5.	`src/BootstrapBlazor/BootstrapBlazor.csproj`

Assessment against linked issues

Issue	Objective	Addressed
#5801	Add an `AutoClose` parameter to the `DateTimeRange` component.	✅
#5801	When `AutoClose` is true, the popup should automatically close after a date range is selected.	✅
#5801	Update documentation to include information about the new `AutoClose` attribute.	✅

Possibly linked issues

feat(DateTimeRange): add AutoClose parameter #5801: The PR implements the feature requested by the issue.
feat(DateTimeRange): add AutoClose parameter #5801: The PR fixes the issue by adding an AutoClose parameter to automatically close the date range picker popup.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Copilot

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)

src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
src/BootstrapBlazor/BootstrapBlazor.csproj: Language not supported

Comments suppressed due to low confidence (2)

test/UnitTest/Components/DateTimeRangeTest.cs:123

[nitpick] Consider translating the comment to English to maintain consistency across the codebase.

// 由于设置了 AutoClose 属性所以这里不需要点击确定按钮

src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs:105

[nitpick] Consider rephrasing the summary to 'Gets or sets whether to automatically close the popup after a date range is selected.' for clarity.

/// Gets or sets whether to auto close the popup when the user selected range value. Default is false.

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding a unit test to verify that the popup does not close when AutoClose is false and a date range is selected.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟡 Testing: 1 issue found
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

codecov · 2025-04-09T04:59:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6bea102) to head (b787186).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5802   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        30072     30079    +7     
  Branches      4246      4247    +1     
=========================================
+ Hits         30072     30079    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)

src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
src/BootstrapBlazor/BootstrapBlazor.csproj: Language not supported

ArgoZhang · 2025-04-09T05:01:03Z

@sourcery-ai review

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding a Close method to the component to allow programmatic closing of the popup, in addition to the AutoClose parameter.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟡 Testing: 1 issue found
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

ArgoZhang added 5 commits April 9, 2025 12:51

feat: 增加 AutoClose 参数

f7ed7ab

doc: 更新文档

e876e9f

test: 更新单元测试

7a74ea9

doc: 增加 AutoClose 说明文档

dc95acb

chore: bump version 9.5.5

ae09597

bb-auto Bot assigned ArgoZhang Apr 9, 2025

bb-auto Bot added the enhancement New feature or request label Apr 9, 2025

bb-auto Bot added this to the v9.5.0 milestone Apr 9, 2025

ArgoZhang requested a review from Copilot April 9, 2025 04:57

ArgoZhang enabled auto-merge (squash) April 9, 2025 04:58

Copilot AI reviewed Apr 9, 2025

View reviewed changes

sourcery-ai Bot previously approved these changes Apr 9, 2025

View reviewed changes

Comment thread test/UnitTest/Components/DateTimeRangeTest.cs

doc: 更新注释文档

b787186

ArgoZhang dismissed sourcery-ai[bot]’s stale review via b787186 April 9, 2025 04:59

ArgoZhang requested a review from Copilot April 9, 2025 05:00

Copilot AI reviewed Apr 9, 2025

View reviewed changes

sourcery-ai Bot approved these changes Apr 9, 2025

View reviewed changes

Comment thread test/UnitTest/Components/DateTimeRangeTest.cs

ArgoZhang merged commit 4d688cb into main Apr 9, 2025
5 checks passed

ArgoZhang deleted the feat-range branch April 9, 2025 05:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(DateTimeRange): add AutoClose parameter#5802

feat(DateTimeRange): add AutoClose parameter#5802
ArgoZhang merged 6 commits intomainfrom
feat-range

ArgoZhang commented Apr 9, 2025 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented Apr 9, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Copilot AI left a comment

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

ArgoZhang commented Apr 9, 2025

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ArgoZhang commented Apr 9, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Summary By Copilot

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

ArgoZhang commented Apr 9, 2025

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ArgoZhang commented Apr 9, 2025 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Apr 9, 2025 •

edited

Loading

codecov Bot commented Apr 9, 2025 •

edited

Loading